Commits links in MR emails point to the commit out of the MR context
Summary
The links in the emails received for MRs point directly to commits, losing the context of the MR.
Steps to reproduce
- Subscribe to get all the possible email notifications for a project
- Create a MR to that project with a different user, then
- Push an additional commit to the branch of the MR, notice the email you received for this action.
Example Project
For example for this MR https://gitlab.gnome.org/GNOME/pitivi/merge_requests/193 I got the following email:
<h3>
XXX pushed new commits to merge request
<a href="https://gitlab.gnome.org/GNOME/pitivi/merge_requests/193">!193</a>
</h3>
<ul>
<li>
<a href="https://gitlab.gnome.org/GNOME/pitivi/commit/1dc9d932">1dc9d932</a>
- markers: add undo/redo operation for comments
</li>
</ul>
What is the current bug behavior?
Link is https://gitlab.gnome.org/GNOME/pitivi/commit/1dc9d932
The link in the email points directly to the commit instead of pointing to the commit in the context of the MR. Because of the direct links, it happens to click and add comments directly on the commit. These comments do appear in the MR, but they cannot be resolved.
What is the expected correct behavior?
Link should be https://gitlab.gnome.org/GNOME/pitivi/merge_requests/193/diffs?commit_id=21c1d1712e287a3c70c48f55a8a83f43af219c47
It would be better if the link points to the commit in the context of the MR, so the comments can be resolved.