Use fixture to test project template update rake task

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

Follow up from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31592

Right now, the spec hits gitlab.com to download the source code of a project template for testing. This is less than ideal for two reasons:

  • It relies on an external system
  • We do not have full control of what is effectively a fixture

(on the other hand, does serve as a decent integration test, but that is maybe more in QA territory)

Improvements

Tests will be faster and cheaper to run, and we can make more assumptions about the contents of vendored fixtures than external ones.

Risks

If the API changes and everything is stubbed, we will not know until it fails for an actual user.

Involved components

  • The gitlab:update_project_templates rake task and its spec will need to be modified
  • A project template fixture will need to be constructed

Optional: Intended side effects

Optional: Missing test coverage

Edited by 🤖 GitLab Bot 🤖