Adding support for feature flags in pages
We're adding host api for gitlab-pages
&1316 (closed)
Can we also return the list of feature flags enabled for the relevant project?
That could make rolling out changes for features like Object Storage Support easier
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Vladimir Shushlin added Category:Pages label
added Category:Pages label
- Author Developer
- Maintainer
@vshushlin Do we need this? For object storage we'll have the information needed in the response as
source
- https://gitlab.com/gitlab-org/gitlab-ce/blob/ba1b3f4573597093c5b6c3f91ea90b5dc2db3ddc/app/models/pages_lookup_path.rb#L23-28 (i.e.source.type
will beurl
). Collapse replies - Author Developer
Good point, I missed that somehow =)
I'd still leave this proposal alive since I often miss having feature flags in pages for rolling out other changes.
- Maintainer
Maybe this will be a good opportunity to start using our own feature flags implementation.
2 Collapse replies - Author Developer
Yes, but we need to wait for user-id strategy then.
- Developer
One next could be to add the Unleash client in to Pages. Work is being done in %12.3 to add it to CE/EE, so there might be a pattern to follow there as well.
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- 🤖 GitLab Bot 🤖 removed [deprecated] Accepting merge requests label
removed [deprecated] Accepting merge requests label
- 🤖 GitLab Bot 🤖 added devopsrelease [DEPRECATED] + 1 deleted label
added devopsrelease [DEPRECATED] + 1 deleted label
- 🤖 GitLab Bot 🤖 added sectionops label
added sectionops label
- Jackie Porter added typefeature label
added typefeature label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#811 (closed)
mentioned in issue gitlab-org/quality/triage-reports#811 (closed)
- Jackie Porter changed milestone to %Backlog
changed milestone to %Backlog
- Jackie Porter added grouprelease [DEPRECATED] label and removed 1 deleted label
added grouprelease [DEPRECATED] label and removed 1 deleted label
- Jackie Porter added grouprelease [DEPRECATED] label and removed 1 deleted label
added grouprelease [DEPRECATED] label and removed 1 deleted label
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- Nicole Williams added devopscreate groupeditor [DEPRECATED] sectiondev labels and removed devopsrelease [DEPRECATED] grouprelease [DEPRECATED] sectionops labels
added devopscreate groupeditor [DEPRECATED] sectiondev labels and removed devopsrelease [DEPRECATED] grouprelease [DEPRECATED] sectionops labels
- 🤖 GitLab Bot 🤖 added groupknowledge label and removed groupeditor [DEPRECATED] label
added groupknowledge label and removed groupeditor [DEPRECATED] label
- 🤖 GitLab Bot 🤖 added devopsplan label and removed devopscreate label
added devopsplan label and removed devopscreate label