Skip to content

'RSS feed' button on commits list for files points to wrong location

Summary

When you try to subscribe to the RSS feed from the history page for a file, the URL points to the feed for the parent directory instead of the file.

Steps to reproduce

  1. Visit: https://gitlab.com/gitlab-org/gitlab-ee/commits/master/CHANGELOG-EE.md

  2. Check the url for the 'RSS feed' button

Example Project

(If possible, please create an example project here on GitLab.com that exhibits the problematic behaviour, and link to it here in the bug report)

(If you are using an older version of GitLab, this will also determine whether the bug has been fixed in a more recent version)

What is the current bug behavior?

The URL is currently:

https://gitlab.com/gitlab-org/gitlab-ee/commits/master?format=atom

(plus an rss_token, which I'm removed as I'm not sure if it's account specific)

and contains articles for the parent directory.

What is the expected correct behavior?

The URL should be:

https://gitlab.com/gitlab-org/gitlab-ee/commits/master/CHANGELOG-EE.md?format=atom

(ie. compared to the incorrect URL '/CHANGELOG-EE.md' is added) which contains only the commits for that file.

Output of checks

This bug happens on GitLab.com

Edited by Joseph Heenan