Rspec spawns many gitaly processes in a loop
This is a local testing problem I'm observing at gitlab-ce@5ea899d34f6332733bb5aee225c5f3ced340cb24.
When I try this:
bundle exec rspec spec/lib/gitlab/git
I see Rspec running some tests, hitting a failure, and then starting over. There may be a maximum number of retries but from a user perspective, this is an endless loop.
This alone is bad, but there is a bigger problem: every time Rspec starts over, it spawns a new Gitaly helper process out of tmp/tests/gitaly
. These helper processes are configured to be terminated when Rspec exits with an at_exit hook. This never happens! So every time Rspec goes into the loop again, it spawns a new Gitaly. It's like a slow motion fork bomb.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Author Contributor
You can see the gitaly processes stack up with
ps -o pid,etime,args -p $(pgrep -f tmp/tests/gitaly/gitaly)
.Edited by Jacob Vosmaer - Author Contributor
If these rspec retries are desired behavior, we should do something to prevent a new gitaly process from being spawned on every rspec retry.
- Jacob Vosmaer added 1 deleted label
added 1 deleted label
- Maintainer
rspec-retry is only enabled in CI though
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- 🤖 GitLab Bot 🤖 removed [deprecated] Accepting merge requests label
removed [deprecated] Accepting merge requests label
- 🤖 GitLab Bot 🤖 added devopsfulfillment devopsgrowth labels
added devopsfulfillment devopsgrowth labels
- 🤖 GitLab Bot 🤖 added devopssystems groupdistribution labels and removed devopsfulfillment devopsgrowth labels
added devopssystems groupdistribution labels and removed devopsfulfillment devopsgrowth labels
- 🤖 GitLab Bot 🤖 added devopscreate groupgitter labels and removed devopssystems groupdistribution labels
added devopscreate groupgitter labels and removed devopssystems groupdistribution labels
- 🤖 GitLab Bot 🤖 added [Deprecated] Category:Runner devopsverify grouprunner labels and removed devopscreate groupgitter labels
added [Deprecated] Category:Runner devopsverify grouprunner labels and removed devopscreate groupgitter labels
- 🤖 GitLab Bot 🤖 added devopscreate groupgitaly labels and removed devopsverify grouprunner labels
added devopscreate groupgitaly labels and removed devopsverify grouprunner labels
- 🤖 GitLab Bot 🤖 added 1 deleted label and removed groupgitaly label
added 1 deleted label and removed groupgitaly label
- 🤖 GitLab Bot 🤖 removed [Deprecated] Category:Runner devopscreate + 1 deleted label
removed [Deprecated] Category:Runner devopscreate + 1 deleted label
- Mark Lapierre added failureflaky-test label
added failureflaky-test label
- Mark Lapierre added Quality label
added Quality label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#155 (closed)
mentioned in issue gitlab-org/quality/triage-reports#155 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#182 (closed)
mentioned in issue gitlab-org/quality/triage-reports#182 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#191 (closed)
mentioned in issue gitlab-org/quality/triage-reports#191 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#223 (closed)
mentioned in issue gitlab-org/quality/triage-reports#223 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#254 (closed)
mentioned in issue gitlab-org/quality/triage-reports#254 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#259 (closed)
mentioned in issue gitlab-org/quality/triage-reports#259 (closed)
- Kyle Wiebers added Category:GDK groupecosystem [DEPRECATED] labels
added Category:GDK groupecosystem [DEPRECATED] labels
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#284 (closed)
mentioned in issue gitlab-org/quality/triage-reports#284 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#292 (closed)
mentioned in issue gitlab-org/quality/triage-reports#292 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#323 (closed)
mentioned in issue gitlab-org/quality/triage-reports#323 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#332 (closed)
mentioned in issue gitlab-org/quality/triage-reports#332 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#349 (closed)
mentioned in issue gitlab-org/quality/triage-reports#349 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#361 (closed)
mentioned in issue gitlab-org/quality/triage-reports#361 (closed)
- 🤖 GitLab Bot 🤖 added sectiondev label
added sectiondev label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#372 (closed)
mentioned in issue gitlab-org/quality/triage-reports#372 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#381 (closed)
mentioned in issue gitlab-org/quality/triage-reports#381 (closed)
- Kyle Wiebers added test label
added test label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#392 (closed)
mentioned in issue gitlab-org/quality/triage-reports#392 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#412 (closed)
mentioned in issue gitlab-org/quality/triage-reports#412 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#421 (closed)
mentioned in issue gitlab-org/quality/triage-reports#421 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#457 (closed)
mentioned in issue gitlab-org/quality/triage-reports#457 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#658 (closed)
mentioned in issue gitlab-org/quality/triage-reports#658 (closed)
- Arturo Herrero added groupintegrations [DEPRECATED] label and removed groupecosystem [DEPRECATED] label
added groupintegrations [DEPRECATED] label and removed groupecosystem [DEPRECATED] label
- 🤖 GitLab Bot 🤖 added 1 deleted label
added 1 deleted label
- Arturo Herrero added groupgitaly label and removed groupintegrations [DEPRECATED] + 1 deleted label
added groupgitaly label and removed groupintegrations [DEPRECATED] + 1 deleted label
- Maintainer
Setting label(s) Category:Gitaly based on groupgitaly.
- 🤖 GitLab Bot 🤖 added Category:Gitaly label
added Category:Gitaly label
- Rémy Coutable closed
closed