Skip to content

Refactor: Delete pipelines_list/blank_state.vue in favor of GlEmptyState

Problem Statement

The component:

  • app/assets/javascripts/pipelines/components/pipelines_list/blank_state.vue

Duplicates the function of <gl-empty-state> from gitlab-ui and provides a similar interface.

image

Proposal

Remove this component and replace it with <gl-empty-state> where used.

This component is used in 2 places via a Vue mixin:

  • app/assets/javascripts/commit/pipelines/pipelines_table.vue
  • app/assets/javascripts/pipelines/components/pipelines_list/pipelines.vue

For this removal I propose:

  • Delete app/assets/javascripts/pipelines/components/pipelines_list/blank_state.vue
  • Remove it from app/assets/javascripts/pipelines/mixins/pipelines.js, where its imported as SvgBlankState.
    • This will reduce the size of the Vue mixin a bit
  • Import GlEmptyState locally into each of the users:
    • app/assets/javascripts/commit/pipelines/pipelines_table.vue
    • app/assets/javascripts/pipelines/components/pipelines_list/pipelines.vue