MR screen: pushing a new commit hides test result dialog, but screen remains dark

Summary

When looking at test result popup in the MR screen while a new commit is pushed to the branch, the dialog disappears, but dark background remains

Steps to reproduce

1.Open a MR detail screen 2. click on failed test to view stacktrace 3. push a new commit to the branch, updating the MR 4. MR screen updates wit hthe new commit, hiding the dialog, but the dark background reminas

Example Project

(If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report)

(If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version)

What is the current bug behavior?

Dialog disappears as soon as the MR is updated, but background stays dark. Page cannot be interacted with until refreshed (e.g. with F5)

What is the expected correct behavior?

Either:

  • Test result dialog should persist until closed manually
  • background should change back together with closing the dialog

Relevant logs and/or screenshots

Screenshot_2019-07-12_11.37.46 Screenshot_2019-07-12_11.38.00

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:         Ubuntu 16.04
Current User:   git
Using RVM:      no
Ruby Version:   2.6.3p62
Gem Version:    2.7.9
Bundler Version:1.17.3
Rake Version:   12.3.2
Redis Version:  3.2.12
Git Version:    2.21.0
Sidekiq Version:5.2.7
Go Version:     unknown

GitLab information
Version:        12.0.3
Revision:       08a51a9db93
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     PostgreSQL
DB Version:     10.7
URL:            (redacted)
HTTP Clone URL: (redacted)
SSH Clone URL:  (redacted)
Using LDAP:     no
Using Omniauth: yes
Omniauth Providers:


GitLab Shell
Version:        9.3.0
Repository storage paths:
  • default: /var/opt/gitlab/git-data/repositories
  • alternative: /media/data/gitlab/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab subtasks ...

Checking GitLab Shell ...


GitLab Shell: ... GitLab Shell version >= 9.3.0 ? ... OK (9.3.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK


Access to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Gitaly ...


Gitaly: ... default ... OK
alternative ... OK


Checking Gitaly ... Finished


Checking Sidekiq ...


Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Checking Incoming Email ...


Incoming Email: ... Reply by email is disabled in config/gitlab.yml


Checking Incoming Email ... Finished


Checking LDAP ...


LDAP: ... LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab App ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
3/6 ... yes
3/7 ... yes
3/8 ... yes
19/9 ... yes
19/10 ... yes
19/11 ... yes
19/12 ... yes
19/13 ... yes
19/14 ... yes
19/15 ... yes
19/16 ... yes
19/17 ... yes
19/18 ... yes
19/19 ... yes
3/20 ... yes
3/21 ... yes
3/22 ... yes
3/23 ... yes
3/24 ... yes
3/25 ... yes
3/26 ... yes
3/27 ... yes
3/28 ... yes
3/29 ... yes
3/30 ... yes
19/31 ... yes
19/32 ... yes
19/33 ... yes
19/34 ... yes
19/35 ... yes
19/36 ... yes
19/37 ... yes
19/38 ... yes
19/39 ... yes
11/40 ... yes
11/41 ... yes
11/42 ... yes
11/43 ... yes
11/44 ... yes
11/45 ... yes
11/46 ... yes
10/47 ... yes
10/49 ... yes
10/50 ... yes
4/51 ... yes
4/52 ... yes
4/53 ... yes
4/54 ... yes
6/56 ... yes
11/57 ... yes
6/58 ... yes
6/59 ... yes
6/61 ... yes
6/62 ... yes
6/63 ... yes
19/64 ... yes
3/65 ... yes
11/66 ... yes
6/67 ... yes
6/68 ... yes
6/69 ... yes
3/70 ... yes
6/71 ... yes
3/72 ... yes
19/73 ... yes
19/74 ... yes
19/75 ... yes
3/76 ... yes
6/77 ... yes
3/78 ... yes
10/79 ... yes
27/80 ... yes
4/81 ... yes
19/82 ... yes
6/83 ... yes
10/84 ... yes
6/85 ... yes
36/86 ... yes
36/87 ... yes
10/88 ... yes
36/89 ... yes
36/90 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.6.3)
Git version >= 2.21.0 ? ... yes (2.21.0)
Git user has default SSH configuration? ... yes
Active users: ... 13


Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished
Edited by Michal Dabski