Resolve technical debt in stages_dropdown.vue
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Resolve technical debt in app/assets/javascripts/jobs/components/stages_dropdown.vue
- In
isMergeRequestPipelineflagsshould be present if we can check formerge_request_pipeline. We should be able to just returnthis.pipeline?.flags?.merge_request_pipelineand it should always already be aBooleanso no need to convert. - We need to check
isTriggeredByMergeRequestI'm not seeingmerge_requestpresent on thepipelineobject. Maybe we can just checkthis.pipeline?.merge_requestwithout converting to aBoolean. Or we can check with backend. - Let's use
data-testidinstead of the legacyjsclasses for testing - Let's use
gitlab-uiutility classes
Edited by 🤖 GitLab Bot 🤖