Discussion: should separate security gate from approvals widget and merge it MR security widget?

Background

In the context of this issue, terminology note: Security gate setup = vulnerability-check setup in Settings(See picture below); Security gate MR widget = MR approval widget

Security gate setup (=vulnerability-check setup) Screenshot_2021-02-02_at_17.56.07 Screenshot_2021-02-02_at_17.56.54
Security gate MR widget(=MR approval widget) Screenshot_2021-02-02_at_18.19.05
MR security widget Screenshot_2021-02-02_at_18.41.19

This is an issue created from original comment and comment. The concerns are around, from a user's perspective:

  • In MR, security widget is more connect with security gate. It follows the mind patter: I see high-risk vulns found, I decide to fix/approve or not. Currently, when the security gate is together with all other approval rules, user need to follow I see high-risk vulns found, they are false positive, but where should I allow it? oh, It is approval rules, I need to go to approval rules widget
  • if we separate security gate from approvals, should we introduce new status to job status, such as block jobs. See illustration below:
No Vulns found Vulns Found
No tech error for pipeline & Security gate disabled pass pass-warning
No tech error for pipeline & Security gate enabled pass pass_but_locked
tech error for pipeline & Security gate disabled failed failed_with_warning
tech error for pipeline & Security gate enabled failed failed_and_blocked

Open question

  1. What are the pros/cons you think to separate security gate from approvals?
Edited by Camellia X Yang