Skip to content

HTML id "stageDropdown" is repeated multiple times in the same page

Description

In contradiction to HTML structure, the id="stageDropdown" is not unique in the page. For example, in the pipelines page (https://gitlab.com/gitlab-org/gitlab/-/pipelines) it is rendered 100+ times.

Screen_Shot_2021-01-25_at_5.57.11_PM

Proposed solution

This is the relevant file: app/assets/javascripts/pipelines/components/pipelines_list/stage.vue

This id is used by the aria-labelledby="stageDropdown" but this wouldn't work in a screen reader as the id is not unique anyway, so we should be able to find an alternative to this.

Edited by Miguel Rincon