Max users count display is inconsistent with system calculation
Summary
Note: A recent change to the max users calculation, shipped in 13.7
Customer is on version 13.5 and their max users seems to be showing the calculation for one year prior to end date (old calculation), however, when trying to upload a renewal license that honors the max count and trueups on the dashboard, the system asks for a trueup count that is different to what is displaying.
It would seem the system wants the trueup count that would have been accurate if the max calculation respected the license start date (i.e the new 13.7 max users calculation).
In summary, it appears that the display for max users calculates according to the pre-13.7 calculation, but the instance actually wants a renewal license that adheres to the 13.7 max users calculation.
There is an inconsistency in what displays and what the system expects for the next license.
Steps to reproduce
- Be on instance with version before 13.7
- License period is 13 months
- Highest number of active users should be in month 1 of the license
- Look at max count display > it should ignore the highest count from month 1 and only show highest count between month 2 - 13
Example
- Ticket: https://gitlab.zendesk.com/agent/tickets/185486
- License details: Premium, start date: 2019-12-19, end date: 2021-01-02
- Usage data: https://version.gitlab.com/usage_data/26984400 (shows high of 12 users since the license start date)
- Admin dashboard: shows the max as 6
What is the expected correct behavior?
The system should be consistent in its max users calculation. If the instance is on version 13.7, the new max users calculation should be honoured. But if the instance is on pre-13.7, the old max users calculation should be used.
