Project name validation is missing when editing project names

Summary

Renaming a project repository with symbols such as ( ) { } [ ] / etc. and then trying to save fails.

Steps to reproduce

  1. Go into the project general settings.
  2. Rename the project name to whatever using these symbols.
  3. Click "Save Changes".

What is the current bug behavior?

The page will not update with "Project [project name] was successfully updated." Instead, it will just sit there until you reload the page, and revert to whatever settings you had before attempting to save.

What is the expected correct behavior?

The user should receive feedback when using disallowed characters. Saving should be disabled when project name is not valid.

Output of checks

This bug happens on GitLab.com.

Proposal

  • Implement the same naming validation check as used during project creation: Screenshot_2024-07-31_at_14.53.46 Screenshot_2024-07-31_at_14.54.21
  • Add support text to name field to describe allowed character set: Screenshot_2024-07-31_at_14.54.01
Edited by Christina Lohr