Refactor Secret Analyzer to fit SAST command interface
Summary
The Secret Detection(SD) analyzer wraps around gitleaks and converts the output of a gitleaks report to a Gitlab secret-detection report. The SD analyzer is like a SAST analyzer in this way. Unlike SAST analyzers, the SD analyzer does not follow the SAST analyzer template (implementing analyze, convert, and using command.run). Instead the SD analyzer implements functions that were most likely relics of having to support two scanners (gitleaks and trufflehog). We should update the SD analyzer to follow the SAST template as this would make the analyzer more familiar for Secure developers and less intimating for community members.
Improvements
Reduced maintenance, and a less intimidating code base for community members who want to contribute
Tasks
-
Refactor SD analyzer to use the SAST template -
Update tests to follow QA naming convention
Edited by Zach Rice