Consider refactoring secure analyzer ruleset package on top of report package
The following discussion from gitlab-org/security-products/analyzers/vulnerability!1 should be addressed:
-
@fcatteau started a discussion: (+1 comment) Side note: I believe
rulesetcould and should be implemented on top ofvulnerability, to increase composability. I know this is out of scope since it comes from the originalissuepackage, but I want to bring that up since this MR is about reorganizing the code. I'll open a MR or refactoring issue to discuss this, if time permits.Conversation starter:
rulesetis just one way to filter the report, similar tofilterpath, and ruleset config is similar to*_EXCLUDED_PATHS. Filter configuration either belongs to the report, or it doesn't. If it doesn't, thenConfigshould be renamed to be more generic, and next step it to describe the configuration as part of thescanobject. If it doesn't, thenrulesetand similar filters should be moved out of thisvulnerabilitypackage.