Error: undefined method `reviewer' for {"reviewer_id"=>1, "state"=>"opened", "non_archived"=>true}:IssuableFinder::Params

Overview

A number of users have recently been getting this error intermittently. gdk restart tends to solve it but it will come back randomly. Sometimes a refresh will solve it, but sometimes it won't and gdk restart is required.

Slack thread: https://gitlab.slack.com/archives/C2Z9A056E/p1609939911229300

Proposal (optional)

Environment (optional)

• Operating System: macOS
• The contents of your gdk.yml

hostname: gdk-saml.test
port: 3443
https:
  enabled: true
nginx:
  enabled: true
  http2:
    enabled: true
  ssl:
    certificate: gdk-saml.test.pem
    key: gdk-saml.test-key.pem

• Ruby version: <!-- output of ruby --version -->
  • ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-darwin19]
• GDK version: <!-- output of git rev-parse --short HEAD -->
  • a292b8e3

added Category:GDK devopscreate groupecosystem [DEPRECATED] labels

added sectiondev label

I'd say this is an issue in gitlab-org/gitlab itself, but it seems to not occur there. When I saw the issue myself, I tried to debug it, but I totally don't get it.

Ahha, it must be related to this line: https://gitlab.com/gitlab-org/gitlab/-/blob/004cd454db4fc650ac34e8f1454837a6cf6e595e/app/finders/issuable_finder.rb#L241

params_class is a method in IssuableFinder, but it must use the one from MergeRequestsFinder. We've seen this before, but my memory is wary on where/what.

Found it: !41835 (merged)

Officially moving to gitlab-org/gitlab now.

moved from gitlab-development-kit#1142 (moved)

changed milestone to %13.8

added regression label and removed Category:GDK label

assigned to @toon

mentioned in commit 171cfebf

mentioned in merge request !51195 (merged)

Fix it at !51195 (merged)

added workflowin review label

added backend label

mentioned in commit 8b1ba0e2

added typebug label

This issue has regression without specifying which milestone introduced it. We're assuming that it's introduced in the current version 13.8.0-pre so we're labeling regression:13.8.

Please correct it accordingly and keep regression so that we could easily search for all the regressions across version, too.

added regression:13.8 label

mentioned in commit 28a4909c

closed with commit 28a4909c

added 1 deleted label and removed devopscreate label

added devopsfoundations label and removed 1 deleted label