Follow-up from "Resolve "Visual regression in 12.0: line numbers not lining up in file view""

The following discussion from gitlab-ce!29403 should be addressed:

• @psimyn started a discussion:

  @tauriedavis do you know if line height should be 1.5 or 1.6?

  I went with 1.5 because that matched the 19px value that was currently there (explained in description). But I noticed that the Commit page uses 1.6 currently. Preview

  table.code tr.line_holder td {
    line-height: 1.6;
    font-size: 90%;
  }

  They are basically the same, I am leaning toward 1.5 since that's what we use basically everywhere else. Can commit line-height be changed or we want the extra breathing room for code?

@pedroms Would you have time to look into this? Its related to typography and line heights

@tauriedavis @annabeldunstone sorry, I don't understand what's the issue here — can you please explain? It looks like the MR solved the visual regression by making it consistent with what we had before changing the “root” font-size to 16px.

@pedroms the inconsistency is MR page diffs have line height of 1.5, and commits page has line height of 1.6.

I assumed line height of 1.5 was correct (so that's what we merged in other MR). If that's the case we should change commits to be 1.5 as well.

added Deferred UX + 1 deleted label

added UX label and removed 1 deleted label

added [deprecated] Accepting merge requests label

removed [deprecated] Accepting merge requests label

added devopsfulfillment devopsgrowth labels

added devopsfulfillment devopsgrowth labels

added devopssystems groupdistribution labels and removed devopsfulfillment devopsgrowth labels

added devopscreate groupgitter labels and removed devopssystems groupdistribution labels

added [Deprecated] Category:Runner devopsverify grouprunner labels and removed devopscreate groupgitter labels

added devopscreate groupgitaly labels and removed devopsverify grouprunner labels

added 1 deleted label and removed groupgitaly label

removed [Deprecated] Category:Runner devopscreate + 1 deleted label

added groupsource code label

Setting devopscreate based on groupsource code.

added devopscreate label

mentioned in issue #216409 (closed)

mentioned in issue #217268 (closed)

mentioned in issue #218187 (closed)

mentioned in issue #218929 (closed)

mentioned in issue #219682 (closed)

mentioned in issue #220716 (closed)

mentioned in issue #222216 (closed)

mentioned in issue #223635 (closed)

mentioned in issue #225116 (closed)

Not sure what changed, but both MR diffs and Commit diffs are now using line-height: 1.6 on GitLab.com. Closing this issue, feel free to comment (or re-open) if you disagree.

closed