Archived projects are still returning / getting hits when doing a global search

Summary

A global search will still reveal hits from projects that are archived. It appears as though this MR should have prevented that from happening.

Steps to reproduce

Create a project that has a very unique string in one of its files.

Archive the project above.

Searching for the unique string mentioned earlier will still reveal search hits, although the project was archived and should have been excluded from the search scope.

Example Project

https://gitlab.com/vstoianovici/my-test-project (this is an archived project, and searching for ajhsdjahdkqhdkhakshdkas will reveal 1 hit)

What is the current bug behavior?

Search hits in archived projects are still being surfaced (they are not excluded from the search scope)

What is the expected correct behavior?

Search hits in archived projects should not be surfaced (they are to be excluded from the search scope).

In fact those projects should be dropped from the index.