[Feature flag] Persist `squash_commit_sha` when squashing
What
Remove the :persist_squash_commit_sha_for_squashes
feature flag ...
Owners
- Team: Create::Source Code
- Most appropriate slack channel to reach out to:
#g_create_source-code-be
- Best individual to reach out to: @vyaklushin
Expectations
What are we expecting to happen?
squash_commit_sha
field in merge_requests
table will be populated for merge requests with enabled squash option.
What might happen if this goes wrong?
squash_commit_sha
field is not populated
What can we monitor to detect problems with this?
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
-
gitlab-org/gitlab
project
Roll Out Steps
-
Confirm that QA tests pass with the feature flag enabled (if you're unsure how, contact the relevant stable counterpart in the Quality department) -
Enable on staging ( /chatops run feature set persist_squash_commit_sha_for_squashes true --staging
) -
Test on staging -
Ensure that documentation has been updated -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour ( /chatops run feature set --project=gitlab-org/gitlab persist_squash_commit_sha_for_squashes true
) -
Coordinate a time to enable the flag with the SRE oncall and release managers - In
#production
mention@sre-oncall
and@release-managers
. Once an SRE on call and Release Manager on call confirm, you can proceed with the rollout
- In
-
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
(/chatops run feature set persist_squash_commit_sha_for_squashes true
) -
Cross post chatops Slack command to #support_gitlab-com
(more guidance when this is necessary in the dev docs) and in your team channel -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry -
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel
Rollback Steps
-
This feature can be disabled by running the following Chatops command:
/chatops run feature set --project=gitlab-org/gitlab persist_squash_commit_sha_for_squashes false
Edited by Vasilii Iakliushin