[sort_diffs] Enable sorting of merge request diffs
What
Enable sort_diffs
feature flag.
Owners
- Team: groupcode review
- Most appropriate slack channel to reach out to:
#g_create_code-review
- Best individual to reach out to: @patrickbajao
Expectations
What are we expecting to happen?
MR diffs are sorted by directory name, depth and file name. List/tree view should be consistent.
What might happen if this goes wrong?
MR diffs are not sorted as expected.
What can we monitor to detect problems with this?
This rails web controller dashboard for Projects::MergeRequests::DiffsController specifically diffs_metadata
and diffs_batch
actions.
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
-
gitlab-org/gitlab
project -
gitlab-com/www-gitlab-com
project
Roll Out Steps
-
Enable on staging ( /chatops run feature set sort_diffs true --staging
) -
Test on staging -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour ( /chatops run feature set --project=gitlab-org/gitlab sort_diffs true
and/chatops run feature set --project=gitlab-com/www-gitlab-com sort_diffs true
) -
Coordinate a time to enable the flag with the SRE oncall and release managers - In
#production
mention@sre-oncall
and@release-managers
. Once an SRE on call and Release Manager on call confirm, you can proceed with the rollout
- In
-
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
(/chatops run feature set sort_diffs true
) -
Announce on the issue that the flag has been enabled
Rollback Steps
-
This feature can be disabled by running the following Chatops command:
/chatops run feature set --project=gitlab-org/gitlab sort_diffs false
Edited by Patrick Bajao