Skip to content

x.509-signed commits to not display as "Verified"/"Unverified" as do GPG-signed commits

Release notes

Problem to solve

Currently, using x.509 as the signing method for commits does not result in either a "Verified" or "Unverified" png image being displayed next to the commit hash. Ex.

Screen_Shot_2020-12-11_at_5.30.47_PM

This feature is implemented for GPG signing. Ex.

Screen_Shot_2020-12-11_at_5.28.13_PM

Proposal

This unverified/verified status should be displayed for x.509-signed commits. Failing this, the documentation for configuration x.509-signed commits should be updated to clearly indicate this absence of this feature for this method of commit signing.

User experience goal

Users who utilize the x.509 key pairs on their smart cards could easily sign and visually verify their commits without having to do so via something like git log --show-signatures.

Additional details

Gitlab EE version: v13.5.4

Gitlab Helm Chart version: 4.5.4

Custom Root CAs have been imported using the method supplied by the helm chart

Edited by Tim Seagren