Breakdown `pipeline_editor_app` into smaller components
Summary
app/assets/javascripts/pipeline_editor/pipeline_editor_app.vue
is a pretty big component already. It would be beneficial to break it down into smaller component and even offset some of it's logic to them when it only concerns the content of one of the tab. The pipeline_editor responsibility should simply be to fetch the data and create the top-most structure of the page
Improvements
- Easier to test
- Separation of concerns
- More readable
Risks
As in any refactoring, this could break the code.
Involved components
app/assets/javascripts/pipeline_editor/pipeline_editor_app.vue
spec/frontend/pipeline_editor/pipeline_editor_app_spec.js
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Frédéric Caplette added frontend grouppipeline authoring typemaintenance labels
added frontend grouppipeline authoring typemaintenance labels
- 🤖 GitLab Bot 🤖 added typefeature label
added typefeature label
- Frédéric Caplette mentioned in merge request !48793 (merged)
mentioned in merge request !48793 (merged)
- Maintainer
Setting label(s) ~"Category:Pipeline Authoring" devopsverify sectionops based on grouppipeline authoring.
- 🤖 GitLab Bot 🤖 added devopsverify sectionops + 1 deleted label
added devopsverify sectionops + 1 deleted label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#1189 (closed)
mentioned in issue gitlab-org/quality/triage-reports#1189 (closed)
- Sarah Groff Hennigh-Palermo mentioned in issue #292229 (closed)
mentioned in issue #292229 (closed)
- Dov Hershkovitch changed milestone to %Backlog
changed milestone to %Backlog
- Sam Beckham marked #285457 (closed) as a duplicate of this issue
marked #285457 (closed) as a duplicate of this issue
- Sam Beckham marked this issue as related to #285457 (closed)
marked this issue as related to #285457 (closed)
- Sam Beckham mentioned in issue #285457 (closed)
mentioned in issue #285457 (closed)
- Developer
@f_caplette are you actively working on this one?
Collapse replies - Author Maintainer
@samdbeckham Not currently no! This was something that came up during a review and that we will need to address in the upcoming milestones.
- Developer
Thanks @f_caplette I'm hoping to get it scheduled in properly, could we get it weighted ? - Author Maintainer
@samdbeckham The work for this require some planning. I would like to make a light architectural proposal that I can run through our team to see if it make sense before we get started on the work. It shouldn't be too much effort and should help determine the complexity, though I think a
3
is a safe weight for this
- Sam Beckham added maintenancerefactor workflowplanning breakdown labels
added maintenancerefactor workflowplanning breakdown labels
- Frédéric Caplette changed the description
Compare with previous version changed the description
- Maintainer
FYI I proposed a small related improvement: #295203 (closed), as it offloads some logic from
pipeline_editor_app
to other components of course this issue is more comprehensive than that Collapse replies - Author Maintainer
@mrincon I've seen that you have proposed working on this early in %13.9. If we are given room to work on it, please feel free to take this one if you wish. I have other issues plan for the early milestones and this one would likely come later in 13.9, or even 13.10. If not, then we can sync to see how to minimize merge conflicts since we would both work on the editor
- Miguel Rincon mentioned in issue gitlab-org/ci-cd/pipeline-authoring#4 (closed)
mentioned in issue gitlab-org/ci-cd/pipeline-authoring#4 (closed)
- Frédéric Caplette set weight to 3
set weight to 3
- Frédéric Caplette mentioned in issue #296861 (closed)
mentioned in issue #296861 (closed)
- Sam Beckham added Deliverable label
added Deliverable label
- Sam Beckham changed milestone to %13.9
changed milestone to %13.9
- Sam Beckham added workflowready for development label and removed workflowplanning breakdown label
added workflowready for development label and removed workflowplanning breakdown label
- Frédéric Caplette added Needs Architecture label
added Needs Architecture label
- Author Maintainer
This issue Needs Architecture, so this is the link to the issue discussing the technical proposal: #299345 (closed)
- Frédéric Caplette created merge request !52200 (merged) to address this issue
created merge request !52200 (merged) to address this issue
- Frédéric Caplette mentioned in merge request !52200 (merged)
mentioned in merge request !52200 (merged)
- Sam Beckham added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Sam Beckham changed health status to on track
changed health status to on track
- Sam Beckham added severity2 label
added severity2 label
- Developer
@f_caplette are the labels on this up to date or is this in workflowverification now?
Collapse replies - Author Maintainer
@samdbeckham Correct, updated thanks!
- Author Maintainer
Verified working on production. Closing
- Frédéric Caplette added workflowverification label and removed workflowin dev label
added workflowverification label and removed workflowin dev label
- Frédéric Caplette added workflowproduction label and removed workflowverification label
added workflowproduction label and removed workflowverification label
- Frédéric Caplette closed
closed
- 🤖 GitLab Bot 🤖 mentioned in issue gl-retrospectives/verify-stage/pipeline-authoring#5 (closed)
mentioned in issue gl-retrospectives/verify-stage/pipeline-authoring#5 (closed)
- Frédéric Caplette marked this issue as related to gitlab-org/ci-cd/pipeline-authoring#8 (closed)
marked this issue as related to gitlab-org/ci-cd/pipeline-authoring#8 (closed)
- 🤖 GitLab Bot 🤖 removed typefeature label
removed typefeature label
- Sunjung Park added workflowcomplete label and removed workflowproduction label
added workflowcomplete label and removed workflowproduction label
- Sunjung Park unassigned @f_caplette
unassigned @f_caplette
- Sunjung Park assigned to @f_caplette
assigned to @f_caplette
- 🤖 GitLab Bot 🤖 added Category:Pipeline Composition label
added Category:Pipeline Composition label