Remove `data-testid="ci-lint-${selector}"` selectors from CI Lint jest tests
Description
Our CI Lint tests in spec/frontend/pipeline_editor/components/lint/
use finders with data-testid="ci-lint-${selector}"
to look for elements in our tests, they should be replaced with data-testid="${selector}"
to make them easier to understand and consistent with the rest of the code.
Original Discussion
The following discussion from !48901 (merged) should be addressed:
-
@sarahghp started a discussion: (+3 comments) I have some concerns about the way this approach makes it hard to grep for
data-testid
s and implies atestid
format; it worries me that it will make it possible to break tests. Since there is just one id we are looking for here, could we be more explicit and do it the usual way, instead of interpolating the string?
Edited by Miguel Rincon