Disable 'Allow editing commits feature' if push rule requires signed commits
Push rules includes an option to reject commits that are not signed, this option can be seen on "Project" > "Settings" > "Repository":
On &4983 (closed), we want to allow commit authors to edit their commit messages on unprotected branches, and on gitaly#3324 (comment 453578753) we discuss we shouldn't allow editing of signed commits.
Proposal
If Reject signed commits
is enabled:
- 'Allow editing commit' should be disabled.
- Maintainers shouldn't be able to enable 'Allow editing commit' feature
Development log
- Jan 13th - !51235 (merged) was merged and deployed to prod
- Jan 25th - follow up opened on #299950 (closed) to make sure we're also dealing with the opposite case
Edited by Mayra Cabrera