UI loses pipeline status icon when child pipeline was started execution
Summary
Gitlab Web UI loses pipeline status on Commits
page when child pipeline was started
Steps to reproduce
- Add any child pipeline with
depend
strategy to the project without child pipelines.
Example Project
Link to the example project page with bug
What is the current bug behavior?
We can see nothing in the red rectangle. The red square was drawn by myself.
What is the expected correct behavior?
We want to see pipeline's correct status.
Relevant logs and/or screenshots
You can find it in the bug description.
Output of checks
This bug happens on GitLab.com.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#1117 (closed)
mentioned in issue gitlab-org/quality/triage-reports#1117 (closed)
- Contributor
@cheryl.li Please can you gauge severity? It appears the pipeline is navigable from the commit itself but that status is not reflected in the list of commits
Collapse replies - Maintainer
Thanks for creating the issue @markglenfletcher! Passing this to our Frontend EM, @samdbeckham, to triage
@dhershkovitch I believe this is a grouppipeline authoring issue?
- Developer
@cheryl.li, yes that's ours what, @samdbeckham let's weight it
- Contributor
@AJIOB Thanks for the detailed report and reproduction project
- 🤖 GitLab Bot 🤖 added sectionops label
added sectionops label
- Dov Hershkovitch added 1 deleted label
added 1 deleted label
- Dov Hershkovitch mentioned in issue gitlab-org/ci-cd/pipeline-authoring#3 (closed)
mentioned in issue gitlab-org/ci-cd/pipeline-authoring#3 (closed)
- Cheryl Li added workflowplanning breakdown label
added workflowplanning breakdown label
- Cheryl Li added grouppipeline authoring label and removed grouppipeline execution label
added grouppipeline authoring label and removed grouppipeline execution label
- Maintainer
Setting label(s) ~"Category:Pipeline Authoring" based on grouppipeline authoring.
- 🤖 GitLab Bot 🤖 added 1 deleted label
added 1 deleted label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#1189 (closed)
mentioned in issue gitlab-org/quality/triage-reports#1189 (closed)
- Developer
Marking this priority2 severity3
@mrincon could you refine and weight this issue for the frontend please?
Edited by Sam Beckham Collapse replies - Maintainer
@samdbeckham This is a backend issue.
- In our HAML template we render the status icon using
commit.status_for(ref)
- In turn the
CommitPresenter
gets the status from thelatest_pipeline
which returnsnil
when usingdepends
.
I managed to "fix" the issue by using
last_pipeline
instead oflatest_pipeline
, but I don't know what could be the implications:diff --git a/app/presenters/commit_presenter.rb b/app/presenters/commit_presenter.rb index c14dcab6000..cf0a9257447 100644 --- a/app/presenters/commit_presenter.rb +++ b/app/presenters/commit_presenter.rb @@ -8,7 +8,8 @@ class CommitPresenter < Gitlab::View::Presenter::Delegated def status_for(ref) return unless can?(current_user, :read_commit_status, commit.project) - commit.latest_pipeline(ref)&.detailed_status(current_user) + # commit.latest_pipeline(ref)&.detailed_status(current_user) + commit.last_pipeline&.detailed_status(current_user) end def any_pipelines?
Labelling as backend and a tentative backend-weight2. Assigning to @cheryl.li in case we want to get a backend team member to have a look.
Edited by Miguel Rincon - In our HAML template we render the status icon using
- Maintainer
cc @iamricecake you authored this code
- Maintainer
@dhershkovitch We didn't add this ~"candidate::13.8", do you want to add this as candidate13.9?
Edited by Cheryl Li - Developer
@cheryl.li not sure, can we weight it regardless?
- Maintainer
@lauraMon Can you take a look at weighting this candidate13.9 issue?
- Maintainer
@cheryl.li Yep, seems that the solution has already been pointed out by @iamricecake - we'd only need to verify that this change works well in the frontend. @mrincon - did you check this on the frontend?
I'd say it's a 1 though!
- Maintainer
Thanks @lauraMon!
@dhershkovitch FYI - Updated as a candidate13.9 issue and workflowready for development
1
- Sam Beckham added priority2 severity3 labels
- Sam Beckham assigned to @mrincon
assigned to @mrincon
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#1247 (closed)
mentioned in issue gitlab-org/quality/triage-reports#1247 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#1355 (closed)
mentioned in issue gitlab-org/quality/triage-reports#1355 (closed)
- Dov Hershkovitch changed milestone to %Backlog
changed milestone to %Backlog
- Miguel Rincon added backend backend-weight2 labels and removed frontend label
added backend backend-weight2 labels and removed frontend label
- Miguel Rincon assigned to @cheryl.li and unassigned @mrincon
assigned to @cheryl.li and unassigned @mrincon
- Cheryl Li assigned to @lauraMon
assigned to @lauraMon
- Cheryl Li unassigned @cheryl.li
unassigned @cheryl.li
- Laura Montemayor set weight to 1
set weight to 1
- Laura Montemayor unassigned @lauraMon
unassigned @lauraMon
- Cheryl Li removed 1 deleted label
removed 1 deleted label
- Cheryl Li added candidate13.9 workflowready for development labels and removed workflowplanning breakdown label
added candidate13.9 workflowready for development labels and removed workflowplanning breakdown label
- Cheryl Li removed backend-weight2 label
removed backend-weight2 label
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- Dov Hershkovitch mentioned in issue gitlab-org/ci-cd/pipeline-authoring#4 (closed)
mentioned in issue gitlab-org/ci-cd/pipeline-authoring#4 (closed)
Collapse replies - Developer
Thanks for reaching out, feel free to open a merge request to fix this issue and one of our developers would help you review your fix
- Maintainer
- Maintainer
Thank you again for your contribution, @genctys!
- Developer
Awesome work @genctys, @fabiopitino thank you for supporting this effort
- Maintainer
@dhershkovitch this is on production now
1
- Dov Hershkovitch removed candidate13.9 label
removed candidate13.9 label
- Cong Chen mentioned in merge request !55657 (merged)
mentioned in merge request !55657 (merged)
- Fabio Pitino added workflowverification label and removed workflowready for development label
added workflowverification label and removed workflowready for development label
- Fabio Pitino changed health status to on track
changed health status to on track
- Fabio Pitino changed milestone to %13.11
changed milestone to %13.11
- Fabio Pitino assigned to @fabiopitino
assigned to @fabiopitino
- 🤖 GitLab Bot 🤖 removed [deprecated] Accepting merge requests label
removed [deprecated] Accepting merge requests label
- Fabio Pitino added workflowproduction label and removed workflowverification label
added workflowproduction label and removed workflowverification label
- Fabio Pitino closed
closed
- Sunjung Park added workflowcomplete label and removed workflowproduction label
added workflowcomplete label and removed workflowproduction label
- Sunjung Park unassigned @fabiopitino
unassigned @fabiopitino
- Developer
It was not my intention to unassign you - so assign you back on the closed issue. Sorry for the unnecessary ping!
- Sunjung Park assigned to @fabiopitino
assigned to @fabiopitino
- 🤖 GitLab Bot 🤖 added Category:Pipeline Composition label
added Category:Pipeline Composition label
- Cheryl Li added pipeline visualizations label
added pipeline visualizations label
- 🤖 GitLab Bot 🤖 added sectionci label and removed sectionops label
added sectionci label and removed sectionops label