The "source_branch" in the "Check out, review, and merge locally" has a leading whitespace, leading to a broken command
I noticed this while trying to merge a gitaly.git
MR from @pks-t locally. If you go to gitaly!2850 (closed) and click "merge locally" step 3 of the recipe is:
git fetch origin
git checkout "master"
git merge --no-ff " pks-tx-conditionally-enable"
Note the leading whitespace before pks-tx
. This results in a broken git invocation, since there's no such branch at this point with a leading whitespace.
Looking at app/views/projects/merge_requests/_how_to_merge.html.haml
I couldn't see what the issue could be other than whitespace in the template variable itself, but maybe I'm missing some subtlety there.