Skip to content

Update License Compliance and Dependency List Empty State Pages

Why are we doing this work

Improving consistency across pages/apps. See #289295 (closed).

Changes needed Screenshot
Dependency List - Button should be replaced with a More information text link at end of description. image
License Compliance - Button should be replaced with a More information text link at end of description. image

Relevant links

Non-functional requirements

  • [-] Documentation:
  • [-] Feature flag:
  • [-] Performance:
  • Testing: Some minor spec tweaks might be necessary.

Implementation plan

  • Dependency List
    • Remove description prop on empty state, instead passing description via default slot.
    • Replace GlDeprecreatedButton with "More information" GlLink via default slot rather than via actions slot, so the link appears inline with the description. No need for GlSprintf, since the More information is a separate sentence from the description, and has already got translations.
  • License Compliance
    • Remove primary-button-* props and description prop from empty state
    • Use default slot in the same was as described above for the Dependency List

Testing

SET should update the E2E tests to include tests for the 'empty state' Tracked at gitlab-org/quality/testcases#1128 (closed)

Edited by Will Meek