2FA login (htop) not working anymore after Upgrading from 11.10.4 to 11.11.0

Summary

I upgraded my Gitlab Source installation from 11.10.4 to 11.11.0. After the upgrade users with 2FA enabled couldn't login anymore because the HTOP tokes were not accepted anymore.

I have a backup from before the upgrade and could try to reproduce the error if that helps, but not within the next couple days.

I tripple checked the secrets file, it is not causing the issue. Other things like runner tokens etc. that depend on the secrets file as well are working normally.

Steps to reproduce

  • Create a user with 2FA enabled on a source install with version 11.10.4.
  • Update the Installation to 11.11.0
  • Try to login

What is the current bug behavior?

2FA enabled users can't login.

What is the expected correct behavior?

2FA enabled users should still be able to login after upgrading.

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:         Gentoo 2.6
Current User:   git
Using RVM:      no
Ruby Version:   2.5.5p157
Gem Version:    3.0.3
Bundler Version:1.17.3
Rake Version:   12.3.2
Redis Version:  4.0.10
Git Version:    2.21.0
Sidekiq Version:5.2.7
Go Version:     go1.12.5 linux/amd64

GitLab information
Version:        11.11.0
Revision:       3e8ca2fb781
Directory:      /opt/gitlabhq-11.11
DB Adapter:     PostgreSQL
DB Version:     11.3
URL:            https://gitlab.isystems.at
HTTP Clone URL: https://gitlab.isystems.at/some-group/some-project.git
SSH Clone URL:  git@gitlab.isystems.at:some-group/some-project.git
Using LDAP:     no
Using Omniauth: yes
Omniauth Providers: github, google_oauth2


GitLab Shell
Version:        9.2.0
Repository storage paths:
  • default: /var/lib/git/repositories GitLab Shell path: /var/lib/gitlab-shell Git: /usr/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab subtasks ...

Checking GitLab Shell ...


GitLab Shell: ... GitLab Shell version >= 9.1.0 ? ... OK (9.2.0)
Running /var/lib/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK


Access to /var/lib/git/.ssh/authorized_keys: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Gitaly ...


Gitaly: ... default ... OK


Checking Gitaly ... Finished


Checking Sidekiq ...


Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Checking Incoming Email ...


Incoming Email: ... Reply by email is disabled in config/gitlab.yml


Checking Incoming Email ... Finished


Checking LDAP ...


LDAP: ... LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab App ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Projects have namespace: ...
4/1 ... yes
6/4 ... yes
7/5 ... yes
7/6 ... yes
7/7 ... yes
7/8 ... yes
7/9 ... yes
7/11 ... yes
5/12 ... yes
5/13 ... yes
5/14 ... yes
5/16 ... yes
5/17 ... yes
5/18 ... yes
5/19 ... yes
5/21 ... yes
5/23 ... yes
5/24 ... yes
5/25 ... yes
5/26 ... yes
5/27 ... yes
5/28 ... yes
5/29 ... yes
5/30 ... yes
2/40 ... yes
2/41 ... yes
2/42 ... yes
9/43 ... yes
9/44 ... yes
9/45 ... yes
8/46 ... yes
8/47 ... yes
8/48 ... yes
10/49 ... yes
10/50 ... yes
8/51 ... yes
2/52 ... yes
11/53 ... yes
5/54 ... yes
2/55 ... yes
12/56 ... yes
12/57 ... yes
12/58 ... yes
15/59 ... yes
10/60 ... yes
2/61 ... yes
2/62 ... yes
2/63 ... yes
5/64 ... yes
2/65 ... yes
5/66 ... yes
5/67 ... yes
2/68 ... yes
2/69 ... yes
2/70 ... yes
2/71 ... yes
2/72 ... yes
5/74 ... yes
2/75 ... yes
2/76 ... yes
12/77 ... yes
12/78 ... yes
5/79 ... yes
2/80 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.5.5)
Git version >= 2.21.0 ? ... yes (2.21.0)
Git user has default SSH configuration? ... yes
Active users: ... 5


Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished
Edited by Jenny