Follow-up from "Remove ignores for terraform state replication"
The following discussion from !48839 (merged) should be addressed:
-
@mayra-cabrera started a discussion: (+3 comments) From our Dropping columns docs, we need to wait for this date to pass :)
This should only get merged with the release indicated with remove_with and once the remove_after date has passed.
Following the guidelines, they say remove in milestone
M+2
, and thatremove_after
should be the release date ofM+2
. But by that logic, it would be impossible to merge inM+2
. Should the guides maybe say the release date ofM+1
?
How else am I supposed to remove it with 13.7? If you really think we should wait another release, that's fine, but I'm not sure it does us any good to wait.
This is a good point. Originally we choose a date that was beyond the release date of M+1
, to make sure that we never package a bunch of changes together that contain both ignoring the column and removing the ignore again (this must be true for both GitLab.com deploys and releases). These dates applied nicely a year ago when we barely deployed to prod, but now that we have daily deployments we may be able to reduce the time span between the three steps required for dropping a column, effectively switching from:
remove_after: set to a date after which we consider it safe to remove the column ignore, typically last date of the development cycle of release M+2 - namely the release date.
To
remove_after: set to a date after which we consider it safe to remove the column ignore, typically the release cycle of M+2