Skip to content

Update profile information summary

Proposal

select-create-new-profile-or-edit

  • Remove scan type from scanner profile selector
  • Remove validation status from site profile selector
  • Add Validation status key/value to site profile section
  • Add None if optional fields have no value (excluded URLs, additional request URLs)

I think we should keep both Name + URL in the site profile selector until we have a better idea of how people are naming profiles.

Implementation Plan

  • Remove scan type from scanner profile selector dropdown
    • Remove addSuffix from scanner_profile_selector
    • Update specs in ee/spec/frontend/on_demand_scans/components/profile_selector/scanner_profile_selector_spec.js
  • Remove validation status from site profile selector dropdown
    • Remove adding suffix from site_profile_selector
    • Update specs in ee/spec/frontend/on_demand_scans/components/profile_selector/site_profile_selector_spec.js
  • Add validation status to Profile Selector summary
    • Update ee/app/assets/javascripts/on_demand_scans/components/on_demand_scans_form.vue to add validation status
    • Update related spec site profile summary
  • Show None for optional fields when value is not set
    • Set default value for ProfileSelectorSummaryCell as None
    • Add spec for this
    • Make sure Excluded Urls & Request headers displays None if empty
Edited by Dheeraj Joshi