Update profile information summary
Proposal
- Remove scan type from scanner profile selector
- Remove validation status from site profile selector
- Add
Validation statuskey/value to site profile section - Add
Noneif optional fields have no value (excluded URLs, additional request URLs)
I think we should keep both Name + URL in the site profile selector until we have a better idea of how people are naming profiles.
Implementation Plan
-
Remove scan typefrom scanner profile selector dropdown-
Remove addSuffixfromscanner_profile_selector -
Update specs in ee/spec/frontend/on_demand_scans/components/profile_selector/scanner_profile_selector_spec.js
-
-
Remove validation statusfrom site profile selector dropdown-
Remove adding suffix from site_profile_selector -
Update specs in ee/spec/frontend/on_demand_scans/components/profile_selector/site_profile_selector_spec.js
-
-
Add validation statusto Profile Selector summary-
Update ee/app/assets/javascripts/on_demand_scans/components/on_demand_scans_form.vueto add validation status -
Update related spec site profile summary
-
-
Show Nonefor optional fields when value is not set-
Set default value for ProfileSelectorSummaryCellasNone -
Add spec for this -
Make sure Excluded Urls & Request headers displays Noneif empty
-
Edited by Dheeraj Joshi
