Merge when pipeline succeeds button > Utilize correct gitlab ui markup
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
The Merge when pipeline succeeds button is utilizing a gl-button component and a gl-dropdown component side by side.
Instead, it should be using the split dropdown component found in GitLab UI: https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-button--dropdown-split-button
The effect of utilizing a gl-button with a gl-dropdown may have been to change the interaction so that when an item is clicked in a dropdown, the action is immediately triggered. However, this creates a disjointed experience with other split buttons in the UI and can be confusing. Rather than making this UI element behave differently, we should utilize gitlab ui and continue to work on gitlab-org/gitlab-services/design.gitlab.com#681 (closed) as a global solution.