Sign in or sign up before continuing. Don't have an account yet? Register now to get started.
Register now

Links to notes in collapsed discussions in the same issue / MR don't work

Steps to reproduce

  1. Open https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10983#note_172823133
  2. Click on "asking for unit test that tested that the component properly rendered if passed an invalid search key" which is a link to https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10983#note_171111050 (A note in a resolved discussion in the same MR)
  3. Observe that clicking on the link doesn't scroll you into that comment

The reason this fails is because #note_171111050 is hidden because resolved discussions are collapsed by default.

Opening https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10983#note_171111050 from another page / in a new tab works because on a new page load we have code that expands the discussion when the note being referred to is hidden.

It seems like this is not happening when opening links to notes in the same issue / MR.

Assignee Loading
Time tracking Loading