CI Linter: Error: Network error: Request failed with status code 500 when the code is

Summary

CI Linter shows Error: Network error: Request failed with status code 500 when the code is on incorrect include.

Steps to reproduce

Use the CI Linter with the following content:

include:
    file: info.yml

Same happens with this example:

include:
    - file: info.yml

Example Project

It is in the Linter, not part of the code.

What is the current bug behavior?

After a few seconds we get an error with status code 500 that seems to indicate that this was a server error.

What is the expected correct behavior?

There should be some explanation that the format of the YAML file is incorrect. Indicate that the project field is required as in this example:

include:
    - file: info.yml
      project: szabgab/ci-linter-error

Alternatively, the CI system and also the linter should assume that if the project field defaults to the current project.

changed the description

mentioned in issue #289476 (closed)

mentioned in issue gitlab-org/quality/triage-reports#1057 (closed)

added grouppipeline security label

removed grouppipeline security label

added devopsverify grouppipeline authoring severity3 typebug + 1 deleted label

added sectionops label

added priority1 severity1 labels and removed severity3 label

mentioned in issue gitlab-org/ci-cd/pipeline-authoring#3 (closed)

added 1 deleted label

@cheryl.li its on the planning issue board, assign for weight if necessary.

changed milestone to %Backlog

added [deprecated] Accepting merge requests label

@mbobin Can you weight and refine this ~"candidate::13.8" issue?

added workflowplanning breakdown label

assigned to @mbobin

removed [deprecated] Accepting merge requests label

I have managed to reproduce this error on .com: https://sentry.gitlab.net/gitlab/gitlabcom/issues/2413833/?query=is%3Aunresolved%20correlation_id%3A01ES96223SHJEACZAZGW53QF1K

It looks like a database timeout error when we are trying to find the project:

  from active_record/relation/finder_methods.rb:81:in `find_by'
  from routable.rb:35:in `find_by_full_path'
  from gitlab/ci/config/external/file/project.rb:46:in `block in project'
  from gitlab/utils/strong_memoize.rb:30:in `strong_memoize'
  from gitlab/ci/config/external/file/project.rb:45:in `project'
  from gitlab/ci/config/external/file/project.rb:51:in `can_access_local_content?'
  from gitlab/ci/config/external/file/project.rb:33:in `validate_content!'
  from gitlab/ci/config/external/file/base.rb:72:in `validate!'
  from gitlab/ci/config/external/file/base.rb:20:in `initialize'
  from gitlab/ci/config/external/file/project.rb:19:in `initialize'
  from gitlab/ci/config/external/mapper.rb:92:in `new'
  from gitlab/ci/config/external/mapper.rb:92:in `block in select_first_matching'
  from gitlab/ci/config/external/mapper.rb:91:in `map'
  from gitlab/ci/config/external/mapper.rb:91:in `select_first_matching'
  from gitlab/ci/config/external/mapper.rb:38:in `map'
  from gitlab/ci/config/external/mapper.rb:38:in `process'
  from gitlab/ci/config/external/processor.rb:12:in `initialize'
  from gitlab/ci/config.rb:89:in `new'
  from gitlab/ci/config.rb:89:in `build_config'
  from ee/gitlab/ci/config_ee.rb:18:in `build_config'
  from gitlab/ci/config.rb:76:in `expand_config'
  from gitlab/ci/config.rb:25:in `initialize'
  from gitlab/ci/yaml_processor.rb:29:in `new'
  from gitlab/ci/yaml_processor.rb:29:in `execute'
  from gitlab/ci/lint.rb:55:in `static_validation'
  from gitlab/ci/lint.rb:30:in `validate'
  from projects/ci/lints_controller.rb:19:in `create'
  from action_controller/metal/basic_implicit_render.rb:6:in `send_action'

I think that it tries to find a project without a path, we might be missing a validation.

added workflowready for development label and removed workflowplanning breakdown label

set weight to 2

unassigned @mbobin

added [deprecated] Accepting merge requests label

changed milestone to %13.8

assigned to @lauraMon

added workflowin dev label and removed workflowready for development label

removed 1 deleted label

removed [deprecated] Accepting merge requests label

Hi @szabgab! It seems like you got the error because you can't use the keyword file without the keyword project. If you try to use the path like so:

include:
   - 'info.yml' # this should work with or without quotes: info.yml or 'info.yml'

this should work. This is probably not clear in the documentation though, so I'm glad you brought it up! I will create an MR to fix that and will make sure we have all necessary validations.

Let me know if this works for you and/or if you have any other comments.

cc @dhershkovitch

mentioned in merge request !50427 (merged)

removed typebug label

@cheryl.li @dhershkovitch I removed the ~bug label as this isn't technically a bug - the timeout can't be reproduced anymore.

@lauraMon, thank you for checking into that, makes sense to me, we can close this issue once your MR is merged

added workflowin review label and removed workflowin dev label

added Deliverable label

added workflowverification label and removed workflowin review label

closed

mentioned in issue gl-retrospectives/verify-stage/pipeline-authoring#4 (closed)

added Category:Pipeline Composition label