"Sent request" not rendering correctly in dark mode on DAST vulnerability pages
Summary
"Sent request" not rendering correctly in dark mode on DAST vulnerability pages, see screenshot below.
Steps to reproduce
https://gitlab.com/gitlab-org/gitlab/-/security/vulnerabilities/3627557
Example Project
https://gitlab.com/gitlab-org/gitlab/-/security/vulnerability_report
What is the current bug behavior?
The sent request is rendered as if I was on the "normal" mode
What is the expected correct behavior?
Colors should be adjusted
Relevant logs and/or screenshots
I use FireFox
Output of checks
This bug happens on GitLab.com
Possible fixes
Within http://gitlab.com/gitlab-org/gitlab/blob/d6b07dfbb88397fd4a2dff9a36d5adf0da9e1a04/app/assets/stylesheets/framework/blocks.scss#L346-347 use variables based on $builds-trace-bg
(either directly re-use or introduce a new variable) to set the background and text-color of .code-block
.
For example:
.code-block {
color: color-yiq($builds-trace-bg);
background-color: $builds-trace-bg;
Edited by David Pisek