Broken master in ./spec/requests/projects/metrics_dashboard_spec.rb
As seen in https://gitlab.com/gitlab-org/gitlab-foss/-/jobs/870696438:
GET /:namespace/:project/-/metrics?environment=:environment.id
returns 200
assigns query param environment
when query param environment does not exist
responds with 404 (FAILED - 1)
1st Try error in ./spec/requests/projects/metrics_dashboard_spec.rb:72:
expected the response to have status code :not_found but it was 200. The response was: <!DOCTYPE html>
<html class="" lang="en">
<snip>
# ./spec/requests/projects/metrics_dashboard_spec.rb:109:in `block (4 levels) in <top (required)>'
# ./spec/spec_helper.rb:347:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:9:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:338:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:334:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:334:in `block (2 levels) in <top (required)>'
Finished in 22 minutes 30 seconds (files took 44.39 seconds to load)
2537 examples, 2 failures, 5 pending
Failed examples:
rspec ./spec/requests/projects/metrics_dashboard_spec.rb:72 # Projects::MetricsDashboardController GET /:namespace/:project/-/metrics?environment=:environment.id when query param environment does not exist responds with 404
rspec ./spec/requests/projects/metrics_dashboard_spec.rb:107 # Projects::MetricsDashboardController GET :/namespace/:project/-/metrics/:dashboard_path?environment=:environment.id when query param environment does not exist responds with 404
SimpleCov failed with exit 1