Vault signing key breaks existing documented way to integrate with Vault
Summary
After upgrading our self hosted GitLab instance to v13.6.1 our existing Vault integration has stopped working.
Steps to reproduce
Set up Vault using the documentation pre current release, specifically the command below.
vault write auth/jwt/config jwks_url="https://gitlab.example.com/oauth/discovery/keys" bound_issuer="gitlab.example.com"
Example Project
n/a
What is the current bug behavior?
The existing JWKS endpoint /oauth/discovery/keys
doesn't have the new Vault signing key introduced in !43950 (merged). As this endpoint was the documented way to integrate with Vault this is a significant breaking change.
This issue is more significant due to hashicorp/vault#9912 which breaks the JWKS upgrade path for Vault.
What is the expected correct behavior?
Returning the same response from /oauth/discovery/keys
and /-/jwks
.
If this wasn't possible then there should have been a release that introduced /-/jwks
and deprecated /oauth/discovery/keys
for Vault integration before the existing behaviour was broken.
Relevant logs and/or screenshots
n/a
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
n/a