Button "Jump to first unresolved discussion" from tab "Changes" does not work for discussion on earlier version of the change

Summary

If a merge request has multiple versions, AND discussions are made for the different versions AND a discussion in an earlier version remains "unresolved"then GitLab may indicated that there are still unresolved discussions (eg. via "8/9 discussions resolved") However, the button Jump to first unresolved discussion in tab "Changes" does NOT lead to the earlier version of the diff WHEN showing the changes between the latest version and base. The button only works when selecting the proper version.

Steps to reproduce

  1. create a merge request in GitLab (Version v11.4.5.)
  2. start a discussion on this initial change
  3. PUSH a new change to GitLab, eg. via "push --force"
  4. add another discussion related to the new change in [version 2]
  5. Compare the "Changes between [version 2] and [base]".
  6. Resolve the discussion on [version 2]
  7. GitLab shows "1/2 discussions resolved".
  8. Open tab Changes. Now click the button Jump to first unresolved discussion.
  9. GitLab will NOT jump to the unresolved discussion in [version 1].

What is the current bug behavior?

button "Jump to first unresolved discussion" in tab Changes does not jump to an unresolved discussion related to an earlier version of the change - there is simply no visible reaction. Workarounds:

  • resolve the discussion from the tab Discussion.
  • identify and navigate to the exact change version where the discussion was started, now press the button Jump to first unresolved discussion - GitLab will jump to the discussion and allow to resolve it.

What is the expected correct behavior?

button Jump to first unresolved discussion will jump to an unresolved discussion related to an earlier version of the change and hence allow to quickly resolve the discussion (not having to search through all earlier versions manually)

Relevant logs and/or screenshots

JumpToFirstUnresolvedDiscussion JumpToFirstUnresolvedDiscussion_worksWhenWithinExactChangeVersion

Output of checks

This bug happens on an internal installation of GitLab CE version v11.4.5.

Edited May 10, 2019 by Paul Jaklitsch
Assignee Loading
Time tracking Loading