Do not reload editor after users after they commit changes in the pipeline editor
Description
Currently, after users commit, no feedback is provided to them and the page simply refreshes:
Original Discussion
The following discussion from !47083 (merged) should be addressed:
Sarah:
One last note here, @mrincon. I pulled the form down to test it manually and I noticed that when we submit the form, it reloads the page (probably because we aren't doing
.defaulton the submit event). We aren't going to want to want to do that in the future though, especially with the expected workflow ofcommit > toggle to see vis > commit > etc.This can just pulled into a followup, too, but I wanted to mention it.
Miguel:
Thanks for checking! It's an MVC to keep the page up to date.
This refresh is intentional,
refreshCurrentPage()is called when the user does not check "open a new MR".
As the "last commit" has changed and we must reload the pipeline chart, is an easy solution is to get everything up to date. It also emulates the way our current edit page works.
We have 2 ways to solve this:
- keep the page reloading and show a flash saying the commit worked
- or try to update the "last commit", pipeline chart, etc.. dynamically.
I would like to pick this up as a UX improvement later and keep it out of the MVC, we will also have more info as the workflow becomes more clear.
