[Feature flag] Rollout of `ci_mr_diff_variables`
What
Remove the :ci_mr_diff_variables
feature flag introduced in !46621 (merged)
Owners
- Team: ~"group::continuous integration"
- Most appropriate slack channel to reach out to:
#g_ci
- Best individual to reach out to: @fabiopitino
Expectations
What are we expecting to happen?
2 new environment variables being calculated and sent to the Runner
What might happen if this goes wrong?
Calculation of variables might be slower causing the overall response time of the request to increase. We don't expect that to occur because finding the diffs for a given MR is already used efficiently today.
What can we monitor to detect problems with this?
-
Ci::CreateCrossProjectPipelineWorker
- execution time -
api/jobs/request
- Database time, Errors, RPS, Execution time.
No entries in Sentry related to the endpoints above
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
-
gitlab-org/gitlab
project -
gitlab-org
/gitlab-com
groups - ...
Roll Out Steps
-
Enable on staging ( /chatops run feature set feature_name true --staging
) -
Test on staging -
Ensure that documentation has been updated -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour ( /chatops run feature set --project=gitlab-org/gitlab feature_name true
) -
Coordinate a time to enable the flag with the SRE oncall and release managers - In
#production
by pinging@sre-oncall
- In
#g_delivery
by pinging@release-managers
- In
-
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
(/chatops run feature set feature_name true
) -
Cross post chatops Slack command to #support_gitlab-com
(more guidance when this is necessary in the dev docs) and in your team channel -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry -
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel
Rollback Steps
-
This feature can be disabled by running the following Chatops command:
/chatops run feature set --project=gitlab-org/gitlab ci_mr_diff_variables false
Edited by Fabio Pitino