Underscore not visible on gitlab pages domain verification, CNAME input

Summary

The underscore is not obvious (see screenshot below) I has not understanding why my domains could not be verified, I had forgot to copy the _ underscore and visual verification did not help ..

The text is _gitlab-pages-verification-code. [...]

Steps to reproduce

• Add a domain to gitlab pages
• See the CNAME verification input

What is the current bug behavior?

The underscore is hidden by the style of the input

What is the expected correct behavior?

See the _ at the start of the input

Relevant logs and/or screenshots

Also related to https://gitlab.com/gitlab-org/gitlab-ce/issues/40241.

/cc @jlenny because ~Release

/cc @nick.thomas because gitlab-ce~4107696

changed milestone to %Backlog

added Category:Pages [deprecated] Accepting merge requests backend default-priority default-severity devopsrelease [DEPRECATED] priority3 severity3 typebug + 1 deleted label

@gtsiolis this is to do with the domain verification, rather than a bad namespace - it's actually required that the created verification domain be _gitlab-pages-verification-code....

Interestingly, this is visible to me (firefox 60.x, debian linux):

So I guess this might be a display bug between different browsers? Can you say what you're using @williamdes ?

cc @leipert due to gitlab-ce@78ff68a2108bb78a9fa488ff995b2111ad837c72 , which is the likely cause of change here.

(Note that these codes are all public, what matters is where they are published, rather than the contents themselves)

@nick.thomas I am using (reproduced on)

• Vivaldi 2.4.1488.38 (Stable channel) (64 bits)
• Google Chrome Version 73.0.3683.103 (Build officiel) (64 bits)
• Opera 60.0.3255.27

@williamdes Interesting. Which platform are you on? I can see it on the same Chrome version on OSX.

@leipert I am using Ubuntu

Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.2 LTS
Release:	18.04
Codename:	bionic

The bug does not exist on Google Chrome (Android) and does not exist on Brave (Android)

I can recreate this in Chrome (it works on Firefox) on elementary OS 0.4.1 Loki which is built on Ubuntu 16.

FYI @pslaughter is my professional account .

FYI @souldzin is my personal account .

This is very similar to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25910, where text was clipped under certain environments. We should double check here that we're handling line heights correctly. It sounds like the environments we develop on are more graceful than others.

mentioned in issue gitlab-pages#238 (closed)

added 1 deleted label

changed milestone to %Backlog

Hi everybody, no updates ?

mentioned in issue gitlab-org/quality/triage-reports#9 (closed)

closed

reopened

@ogolowinski could we get your eyes on this issue? It looks like there's some environments that clip the leading underscore of this text which could result in the user seemingly following instructions but not entering the right verification value.

Any chance this could be assigned and scheduled in %12.10?

@pslaughter this is actually under @jmeshell today

@pslaughter - I will queue it up for weighting in 12.10 and hopefully we can pull it in.

removed 1 deleted label

added cicdplanning needs weight workflowplanning breakdown labels

mentioned in issue #208964 (closed)

I could not reproduce on MacOS 10.15.3 with Chrome 80.0.3987.149 nor Safari 13.0.5. However it seems like a frontend issue based on #28448 (comment 215757081)

I believe it would be a simple fix so adding issue weight 1, @nfriend could you please confirm?

Thanks @jaime for taking a look

@jaime I haven't reproduced this myself, but based on @pslaughter's comment above, this sounds like a frontend-weight1

removed needs weight label

changed weight to 1

added cicdactive workflowscheduling labels and removed cicdplanning workflowplanning breakdown labels

added 1 deleted label

added frontend-weight1 label

removed 1 deleted label

added [deprecated] low hanging fruit label

added sectionops label

added [deprecated] good for new contributors label

Possible community issue https://gitlab.com/gitlab-org/ci-cd/release-management-group/release-management/-/issues/48

added grouprelease [DEPRECATED] label and removed 1 deleted label

added frontend label and removed backend label

removed cicdactive label

I remember not seeing the _ when I first tried out GitLab Pages a few months ago. Trying to find out what I had done wrong was immensely frustrating and time-consuming. Eventually I was able to discover what I did wrong by looking at the docs on docs.gitlab.com but even that took me a while. (If I remember correctly, I think there was even a place where even the docs didn't have the _ but the docs have either improved significantly since then or I was extraordinarily blind, since it's relatively easy to discover the correct name now.)

Would be good to have this visual glitch fixed.

added UX label

added 1 deleted label

added devopscreate groupeditor [DEPRECATED] sectiondev labels and removed devopsrelease [DEPRECATED] grouprelease [DEPRECATED] sectionops labels

added vintage label

Hi @williamdes ,

Thanks for raising this bug.

Contributions like this are vital to help make GitLab a better product.

We would be grateful for your help in verifying whether your bug report requires further attention from the team. If you think this bug still exists, and is reproducible with the latest stable version of GitLab, please comment on this issue.

This issue has been inactive for more than 12 months now and based on the policy for inactive bugs, will be closed in 7 days.

Thanks for your contributions to make GitLab better!

added stale label

removed stale label

@oregand: This looks like a good SUSImpacting issue to pick up for upcoming milestones.

Perfect, lets add it as a Stretch

added Stretch label

changed milestone to %15.5

assigned to @ealcantara

removed [deprecated] Accepting merge requests label

changed milestone to %15.7

added quick win label and removed [deprecated] low hanging fruit label

@ealcantara This issue looks like it may slip this current milestone. Can you leave a or to signify if you are on track to deliver this issue? Please also consider updating the issue's Health Status or Milestone to reflect its current state, and communicate with your Product Manager as appropriate.

Bot policy.

/cc @ericschurter

unassigned @ealcantara

I will move this issues to the backlog until we have the capacity to pick SUS issues again.

changed milestone to %Backlog

I wasn't able to recreate this, I am reaching out to see if anyone else is able to

I suspect this may have been fixed inadvertently by !102347 (merged). Depending on the system font that resolved previously, anyway! For me, here's the before/after:

simplescreenrecorder-2023-02-06_15.28.33

Note the much lower vertical position of the underscore. The higher position is with JetBrains Mono (soon to be GitLab Mono).

I'm going to go ahead and close it then.

If anyone is still able to recreate this issue, let me know and I will reopen.

Thanks for checking @markrian

closed