Fix the`max-nesting-depth` style-lint errors and warnings for `app/assets/stylesheets/pages/notes.scss`
Problem
Fix the following style-lint errors and warnings for app/assets/stylesheets/pages/notes.scss
196:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
249:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
271:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
277:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
291:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
298:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
302:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
307:11 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
311:11 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
315:11 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
467:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
470:11 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
475:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
479:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
905:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
909:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
917:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
What to do
- If possible, replace the CSS class with a utility one, check common.scss and https://getbootstrap.com/docs/4.4/utilities/ for existing ones
- Double check if all the warning have been fixed by running
stylelint app/assets/stylesheets/pages/notes.scss
- In the MR, add screenshots of the affected areas before and after the changes, check the first MR as a guideline
- If there are a lot of changes, we recommend to break them into smaller MRs
- Double check the usage of each changed class both in CE and EE
- EE changes should either be backported into CE or moved into
ee/
folder. You can read more about how to handle EE code here - Label the MR with CSS cleanup
Important
Do not check the warnings with yarn lint:stylelint
command as it's running with -q
flag that ignores warnings that are listed here even though the issues are still valid. Please run stylelint app/assets/stylesheets/pages/notes.scss
directly to get the actual list of warnings.
Edited by Denys Mishunov