Skip to content

GitLab Next

Closed
Opened by Jean@antfobe

Dropdown accepts arbitrary inputs

Summary

At pipelines/new page, the input below the 'Run for' label accepts arbitrary strings that are not valid branches. Me and @leonardofl believe this to be a bug, given there is no sense in inputting an arbitrary value in this context and that such behavior is not found in other dropdowns in gitlab-ce views. (e.g. selecting Assignee and Milestone at issues/new page presents correct behavior)

Steps to reproduce

  1. Select any project that your user can run a pipeline
  2. On the left-side menu of the project view click CI/CD -> Pipelines
  3. On the pipelines view click on the button 'Run pipeline'
  4. The input below the 'Run for' label can accept any string

Example Project

Can be seen on gitlab.com/antfobe/gitlab-ce

What is the current bug behavior?

Input accepts arbitrary strings, but should only accept brach names.

What is the expected correct behavior?

The input should not register strings that are not brach names.

Relevant logs and/or screenshots

Screenshot_from_2019-04-24_16-18-55

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

Expand for output related to GitLab environment info 
bin/rake gitlab:env:info


System information
System:		Arch rolling
Current User:	fobe
Using RVM:	no
Ruby Version:	2.5.3p105
Gem Version:	2.7.6
Bundler Version:1.17.3
Rake Version:	12.3.2
Redis Version:	5.0.4
Git Version:	2.21.0
Sidekiq Version:5.2.5
Go Version:	go1.12.4 linux/amd64

GitLab information
Version:	11.11.0-pre
Revision:	bba3cfdc122
Directory:	/opt/gdk-ce/gitlab
DB Adapter:	PostgreSQL
DB Version:	11.2
URL:		http://localhost:3000
HTTP Clone URL:	http://localhost:3000/some-group/some-project.git
SSH Clone URL:	ssh://fobe@localhost:2222/some-group/some-project.git
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers: 

GitLab Shell
Version:	9.0.0
Repository storage paths:
- default: 	/opt/gdk-ce/repositories
GitLab Shell path:		/opt/gdk-ce/gitlab-shell
Git:		/usr/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
bin/rake gitlab:check SANITIZE=true


Checking GitLab subtasks ...

Checking GitLab Shell ...

GitLab Shell: ... GitLab Shell version >= 9.0.0 ? ... OK (9.0.0)
Running /opt/gdk-ce/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK

Access to /opt/gdk-ce/.ssh/authorized_keys: OK
gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Gitaly ...

Gitaly: ... default ... OK

Checking Gitaly ... Finished

Checking Sidekiq ...

Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking Incoming Email ...

Incoming Email: ... Reply by email is disabled in config/gitlab.yml

Checking Incoming Email ... Finished

Checking LDAP ...

LDAP: ... LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab App ...

Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... no
  Try fixing it:
  sudo chmod 700 /opt/gdk-ce/gitlab/public/uploads
  For more information see:
  doc/install/installation.md in section "GitLab"
  Please fix the error above and rerun the checks.
Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet)
Init script exists? ... no
  Try fixing it:
  Install the init script
  For more information see:
  doc/install/installation.md in section "Install Init Script"
  Please fix the error above and rerun the checks.
Init script up-to-date? ... can't check because of previous errors
Projects have namespace: ... 
2/1 ... yes
2/2 ... yes
3/3 ... yes
4/4 ... yes
5/5 ... yes
6/6 ... yes
7/7 ... yes
8/8 ... yes
18/9 ... yes
30/10 ... yes
36/11 ... yes
9/12 ... yes
53/13 ... yes
25/14 ... yes
23/15 ... yes
10/16 ... yes
38/17 ... yes
50/18 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.5.3)
Git version >= 2.21.0 ? ... yes (2.21.0)
Git user has default SSH configuration? ... no
  Try fixing it:
  mkdir ~/gitlab-check-backup-1556136270
  sudo mv /home/fobe/.ssh/id_rsa ~/gitlab-check-backup-1556136270
  sudo mv /home/fobe/.ssh/id_rsa.pub ~/gitlab-check-backup-1556136270
  For more information see:
  doc/ssh/README.md in section "SSH on the GitLab server"
  Please fix the error above and rerun the checks.
Active users: ... 49

Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished