DAST: Remove On-demand landing page
Overview
The On-demand landing page was originally thought of as a one-time only page that would only show up if you've never run a scan before. Also, once other scanners use on-demand scans, it can be a way to select which scanner you want to use to create the scan. However, since DAST is currently the only scanner that uses on-demand scans and the landing page shows up every time you click on the link from the left nav, we should remove the page until we can have a more useful reason for the landing page to be shown.
Problem
The on-demand landing page shows up every time you click on the link in the left nav, but the page is useless as is and only creates an extra click to get where you want to go.
Solution
Remove the current landing page and replace it with the On-demand DAST scan configuration page. This can be the workflow until we have a reason to reintroduce a more useful landing page.
Non-functional requirements
-
Documentation: No updates needed for https://docs.gitlab.com/ee/user/application_security/dast/#on-demand-scans -
Feature flag: No -
Performance: -
Testing: Unit tests should be updated. No end-to-end coverage exists on this yet.
Implementation plan
-
For /on_demand_scans -
Remove the landing page code -
Show the New on-demand DAST scan
initially
-