[Feature flag] Enable environment auto-stop start on create
What
Remove the :environment_auto_stop_start_on_create
feature flag ...
Owners
- Team: ~"group::release"
- Most appropriate slack channel to reach out to:
#s_release
- Best individual to reach out to: @atroschinetz
Expectations
What are we expecting to happen?
Environments will initially begin their auto-stop countdown at creation time instead of at the time of the first successful deployment to that environment.
What might happen if this goes wrong?
From @shinya.maeda at !47239 (comment 445513162)
Since these
seed/*
are core logic in pipeline creation, it's quite sensitive to errors that could harm the CI availability on gitlab.com. I know this change logically works, but I wonder if it's worth using a feature flag to gradually rollout the change.Also, this change could be a breaking change to some users, as they might rely on the current behavior that the auto stop period is not set at creation. So it's safer to use a feature flag to let SREs easily switch back the previous behavior, without reverting this MR and hot-patch production.
What can we monitor to detect problems with this?
I'm not sure issues would crop up in dashboards. We might get contacted by customers relying on the previous behavior if their pipelines begin to have unexpected and incorrect behavior after turning this on.
Beta groups/projects
Not any.
Roll Out Steps
-
Enable on staging ( /chatops run feature set environment_auto_stop_start_on_create true --staging
) -
Test on staging -
Ensure that documentation has been updated -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour (It's not possible to enable this flag on a per-project basis./chatops run feature set --project=gitlab-org/gitlab environment_auto_stop_start_on_create true
) -
Coordinate a time to enable the flag with the SRE oncall and release managers - In
#production
by pinging@sre-oncall
- In
#g_delivery
by pinging@release-managers
- In
-
Announce on the issue an estimated time this will be enabled on GitLab.com: !47239 (comment 447393548) -
Enable on GitLab.com by running chatops command in #production
(/chatops run feature set environment_auto_stop_start_on_create true
) -
Cross post chatops Slack command toin your team channel#support_gitlab-com
(more guidance when this is necessary in the dev docs) and -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry: !47702 (merged) -
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel
Rollback Steps
- [-]
This feature can be disabled by running the following Chatops command:
/chatops run feature set environment_auto_stop_start_on_create false