Show runner installation instructions for Docker and Kubernetes are broken
Release notes
Problem to solve
In issue 214587, Change redirect for link “Install GitLab Runner” to a pop up, a new pop for Runner installation instructions was added to the UI. However the installation instructions for Docker and Kubernetes currently only displays a link to the docs page and blank content for the Register Runner - Method panel.
2020-11-13: Also, Viktor Nagy pointed out the following in the linked video:
- The initial load time for the pop up is slow.
- The panel content should reflect the tab that the user has selected.
- The copy selection for the install instructions does not work.
Proposal
Let's revert the MR that introduced those changes: !42877 (merged)
Follow-up
For the Docker and Kubernetes installation instructions implement the following:
- Change the "download and install binary" heading to "Installation"
- For Docker, add the text "To install Runner in a container follow the instructions described in the GitLab documentation"
- For Kubernetes, add the text, "To install Runner in Kubernetes follow the instructions described in the GitLab documentation."
- For both Docker and Kubernetes add a button with label =
View installation instructions
- For Docker, the
View installation instructions
will redirect the user to the runner docs page for the docker installation instructions. https://docs.gitlab.com/runner/install/docker.html - For Kubernetes, the
View installation instructions
will redirect the user to the runner docs page for the Kubernetes installation instructions. https://docs.gitlab.com/runner/install/kubernetes.html
Edited by Adrien Kohlbecker