Web IDE allows user to both commit to master and create a new merge request

When editing a repo directly on the master branch, the Web IDE gives me the option to both commit directly to master and create a new merge request:

image

Upon clicking the "Commit" button, the following page renders a large error message since the source branch and the target branch are the same:

image

As mentioned in a Slack conversation, this workflow makes sense when working on a branch other than master or in a fork. However, it's not intuitive when commiting directly to master on the upstream repo.

Some possible solutions

  • Disable the "Start a new merge request" option when committing directly to master (and not in a fork)
  • Explicitly show what the target branch will be in the UI
  • All of the above
Edited Apr 15, 2019 by Achilleas Pipinellis
Assignee Loading
Time tracking Loading