Fix the following style-lint errors and warnings for `app/assets/stylesheets/pages/diff.scss`
Problem
Fix the following style-lint errors and warnings for app/assets/stylesheets/pages/diff.scss
(at 8af7ad94)
$ $(yarn bin)/stylelint app/assets/stylesheets/framework/diffs.scss
app/assets/stylesheets/framework/diffs.scss
459:25 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
460:19 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
464:31 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
465:25 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
466:18 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
472:11 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
473:5 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
524:6 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
567:3 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
575:13 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
576:7 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
582:13 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
583:7 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
641:26 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
641:47 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
669:18 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
681:37 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
873:7 ⚠ ".diff-stats-additions-deletions-expanded, .inline-parallel-buttons" has the same properties as our BS4 utility class ".d-none (176:1)" so please stylelint-gitlab/utility-classes
use that instead.
882:7 ⚠ ".diff-stats-additions-deletions-collapsed" has the same properties as our BS4 utility class ".d-block (185:1)" so please use that instead. stylelint-gitlab/utility-classes
923:3 ⚠ ".diff-changed-file-name, .diff-changed-blank-file-name" has the same properties as our BS4 utility class ".text-truncate (1853:1)" so please use that stylelint-gitlab/utility-classes
instead.
What to do
- If possible, replace the CSS class with a utility one, check common.scss and https://getbootstrap.com/docs/4.4/utilities/ for existing ones
- Double check if all the warning have been fixed by running `yarn run stylelint-file app/assets/stylesheets/pages/diff.scss``
- In the MR, add screenshots of the affected areas before and after the changes, check the first MR as a guideline
- If there are a lot of changes, we recommend to break them into smaller MRs
- Double check the usage of each changed class both in CE and EE
- EE changes should either be backported into CE or moved into
ee/
folder. You can read more about how to handle EE code here - Label the MR with CSS cleanup
Edited by Takuya Noguchi