Fix the following style-lint errors and warnings for app/assets/stylesheets/framework/typography.scss
Problem
Fix the following style-lint errors and warnings for app/assets/stylesheets/framework/typography.scss
29:5 ⚠ Expected ".md:not(.use-csslab) p a:not(.no-attachment-icon) img" to have no more than 3 compound selectors selector-max-compound-selectors
39:5 ⚠ "> code" and "a (/Users/filipalacerda/Documents/git/gitlab-development-kit/gitlab/app/assets/stylesheets/framework/typography.scss -36:3)" have the same properties. stylelint-gitlab/duplicate-selectors
167:5 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
168:5 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
181:7 ⚠ Expected ".md:not(.use-csslab) table:not(.code) tr th" to have no more than 3 compound selectors selector-max-compound-selectors
185:7 ⚠ Expected ".md:not(.use-csslab) table:not(.code) tr td" to have no more than 3 compound selectors selector-max-compound-selectors
237:7 ⚠ Expected ".md:not(.use-csslab) > ul ul ul" to have no more than 3 compound selectors selector-max-compound-selectors
263:7 ⚠ Expected ".md:not(.use-csslab) ul.task-list > li.task-list-item > input.task-list-item-checkbox" to have no more than 3 compound selectors selector-max-compound-selectors
400:3 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
404:1 ⚠ Expected ".git-revision-dropdown .dropdown-content ul li a" to have no more than 3 compound selectors selector-max-compound-selectors
405:3 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
What to do
- If possible, replace the CSS class with a utility one, check common.scss and https://getbootstrap.com/docs/4.3/utilities/ for existing ones
- Double check if all the warning have been fixed by running
yarn run stylelint-file app/assets/stylesheets/framework/typography.scss - In the MR, add screenshots of the affected areas before and after the changes, check the first MR as a guideline
- If there are a lot of changes, we recommend to break them into smaller MRs
- Double check the usage of each changed class both in CE and EE
- EE changes should either be backported into CE or moved into
ee/folder. You can read more about how to handle EE code here - Label the MR with gitlab-ce~10109752
Edited by 🤖 GitLab Bot 🤖