Fix the following style-lint errors and warnings for app/assets/stylesheets/framework/common.scss
Problem
Fix the following style-lint errors and warnings for app/assets/stylesheets/framework/common.scss
133:1 ⚠ ".block-truncated" has the same properties as our BS4 utility class ".text-truncate (1853:1)" so please use that instead. stylelint-gitlab/utility-classes
188:5 ⚠ "li" has the same properties as our BS4 utility class ".border-bottom-0 (113:1)" so please use that instead. stylelint-gitlab/utility-classes
200:1 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
238:1 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
242:1 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
274:3 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
275:3 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
295:1 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
296:3 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
What to do
- If possible, replace the CSS class with a utility one, check common.scss and https://getbootstrap.com/docs/4.4/utilities/ for existing ones
- Double check if all the warning have been fixed by running
yarn run stylelint-file app/assets/stylesheets/framework/common.scss - In the MR, add screenshots of the affected areas before and after the changes, check the first MR as a guideline
- If there are a lot of changes, we recommend to break them into smaller MRs
- Double check the usage of each changed class both in CE and EE
- EE changes should either be backported into CE or moved into
ee/folder. You can read more about how to handle EE code here - Label the MR with CSS cleanup
Edited by 🤖 GitLab Bot 🤖