[ci_lint_creates_pipeline_with_dry_run] Remove and clean up feature flag
What
Cleanup the :ci_lint_creates_pipeline_with_dry_run
feature flag, whichi lives in a "zombie" mode, that may cause confusing states for users.
Backgroung: We ported the lint page to Vue, and in this new implementation we ignore the feature flag when displaying the "dry run" checkbox, the checkbox is always shown.
As the vue port is now the only version of the page (rollout #233904 (closed)), disabling the ci_lint_creates_pipeline_with_dry_run
feature flag would bring unexpected results for users: They would see the checkbox, but it would have no effect!
Owners
- Team: grouppipeline authoring
- Most appropriate slack channel to reach out to:
#g_pipeline-authoring
- Best individual to reach out to: @mrincon
Expectations
What are we expecting to happen?
This "abandoned" feature flag is completely removed to avoid confusing users and admins.
What might happen if this goes wrong?
What can we monitor to detect problems with this?
Roll Out Steps
The rollout steps have been reduced, to match the current status of this flag:
-
Remove feature flag -
Remove references in the code (e.g. from Gitlab::Ci::Features
) -
Ensure dry run
documentation is up to date -
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel
Rollback Steps
-
This feature can be disabled by running the following Chatops command:
/chatops run feature set --project=gitlab-org/gitlab feature_name false
Edited by Miguel Rincon