[Feature flag] Rollout of `query_cache_for_load_balancing`
What
Remove the :query_cache_for_load_balancing
feature flag ...
Owners
- Team: Memory
- Most appropriate slack channel to reach out to:
#g_memory
- Best individual to reach out to: @nmilojevic1
Expectations
What are we expecting to happen?
We are expecting that this will reduce the number of executed SQL queries database replica. We expect that request times for some queries should be improved.
What might happen if this goes wrong?
This can slightly increase memory pressure on our application (especially in some cases where we have N+1 query problem, masked by cached queries).
What can we monitor to detect problems with this?
- Postgres: https://dashboards.gitlab.net/d/000000144/postgresql-overview?orgId=1
- Memory CPU: https://dashboards.gitlab.net/d/general-service/general-service-platform-metrics?orgId=1&from=now-2d&to=now&var-PROMETHEUS_DS=Global&var-environment=gprd&var-type=web&var-stage=main&var-sigma=2
- Kibana: https://log.gprd.gitlab.net/goto/d893856412d7a8f284ad8d8c59b173c1
Roll Out Steps
-
Enable on staging ( /chatops run feature set feature_name true --staging
) -
Test on staging -
Ensure that documentation has been updated -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour ( /chatops run feature set --project=gitlab-org/gitlab feature_name true
) -
Coordinate a time to enable the flag with the SRE oncall and release managers - In
#production
by pinging@sre-oncall
- In
#g_delivery
by pinging@release-managers
- In
-
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
(/chatops run feature set feature_name true
) -
Cross post chatops Slack command to #support_gitlab-com
(more guidance when this is necessary in the dev docs) and in your team channel -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry -
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel
Rollback Steps
-
This feature can be disabled by running the following Chatops command:
/chatops run feature set --project=gitlab-org/gitlab query_cache_for_load_balancing false
Edited by Nikola Milojevic